[codegen] Track thumbv7m-none-eabi, riscv32imc-unknown-none-elf#3103
Open
[codegen] Track thumbv7m-none-eabi, riscv32imc-unknown-none-elf#3103
Conversation
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's codegen testing capabilities by integrating two new embedded targets, ARM Cortex-M3 and RISC-V 32-bit. This expansion ensures broader compatibility and performance validation for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request extends the codegen tests to track assembly output for thumbv7m-none-eabi and riscv32imc-unknown-none-elf targets, in addition to the existing x86-64 target. This is achieved by introducing a new test harness crate codegen-benches and updating the codegen test logic to iterate over multiple ISA configurations. The changes look good and improve test coverage for different architectures. I have a couple of suggestions to improve the maintainability of the new codegen-benches crate.
joshlf
force-pushed
the
Gendq4lo5ioqhx5sfxgkq7iza57vwhm6e
branch
from
d88327b to
5af12b8
Compare
joshlf
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gebjymcx3pko5oy6wx4qr4i6er4i3iodm #3103 +/- ##
==================================================================
Coverage 91.87% 91.87%
==================================================================
Files 20 20
Lines 6057 6057
==================================================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gherrit-pr-id: Gebjymcx3pko5oy6wx4qr4i6er4i3iodm
gherrit-pr-id: Gendq4lo5ioqhx5sfxgkq7iza57vwhm6e
joshlf
force-pushed
the
Gebjymcx3pko5oy6wx4qr4i6er4i3iodm
branch
from
4993d04 to
e62a49e
Compare
joshlf
force-pushed
the
Gendq4lo5ioqhx5sfxgkq7iza57vwhm6e
branch
from
5af12b8 to
03a52b6
Compare
jswrenn
reviewed
Mar 10, 2026
| mov rcx, rsi | ||
| cmp rsi, 6 | ||
| jne .LBB5_2 | ||
| jne .LBB0_2 |
Collaborator
There was a problem hiding this comment.
Separate from accepting this PR, it looks like we'll need to implement some form of label normalization.
Member
Author
There was a problem hiding this comment.
IIUC this is just because we're changing how compilation works (compiling in a different context with different numbers of basic blocks), which is why this changed. It should still be stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yqandjq#3104Latest Update: v3 — Compare vs v2
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gendq4lo5ioqhx5sfxgkq7iza57vwhm6e && git checkout -b pr-Gendq4lo5ioqhx5sfxgkq7iza57vwhm6e FETCH_HEADCheckout
git fetch origin refs/heads/Gendq4lo5ioqhx5sfxgkq7iza57vwhm6e && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gendq4lo5ioqhx5sfxgkq7iza57vwhm6e && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.