Fix filepath collector panic #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the situation is in the rare case when the filepath package can't walk, yamlfmt will then call a function on a nil fileinfo which will panic. This PR adds handling for the error from filepath walking which will print the errors for the paths it can't read and format what it is capable of formatting.
braydonk
force-pushed
the
fix_filepath_walk_panic
branch
from
48d0521 to
eafbfcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300 (congrats on the nice round issue number)
Currently, the situation is in the rare case when the filepath package can't walk, yamlfmt will then call a function on a nil fileinfo which will panic. This PR adds handling for the error from filepath walking which will print the errors for the paths it can't read and format what it is capable of formatting.