Solving missing line param on gitlab coequality #294
Conversation
adjust lines properties on gitlab report
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
braydonk
left a comment
braydonk
left a comment
There was a problem hiding this comment.
The changes to the comments are nonsensical. I get the sense an AI Agent was too aggressive with them. Please restore all changed godoc comments to their original form.
In addition, please update the PR title and description to provide explanation and documentation about this from GitLab. What you've provided is insufficient for me to feel confident in the PR and review.
A compliant report need to output lines on "location" object to work properly as doc in link show us: https://docs.gitlab.com/ci/testing/code_quality/ This commit write de "lines" property properly. If "location" object don't output the line, the gitlab show a message saying "Failed to load Code Quality report"
braydonk
left a comment
braydonk
left a comment
There was a problem hiding this comment.
Same request as above.
slipknois
changed the title
I changed the title, restored the comments to their original state... Is there anything else that needs adjusting? I'm trying to resolve this issue because the generated report wasn't compliant with GitLab, and I'm having problems because GitLab can't read the report file! |
braydonk
left a comment
braydonk
left a comment
There was a problem hiding this comment.
This PR also needs a tests added. I would recommend adding a testdata folder and having a before and after of a formatted yaml file with a reasonable number of lines, and expect a particular Lines.Begin value from the created code quality (i.e. the line this detects as first differing is what the codequality report produces).
|
|
||
| // Lines follows the GitLab Code Quality schema. | ||
| type Lines struct { | ||
| Begin *int `json:"begin,omitempty"` |
There was a problem hiding this comment.
My previous comment was for the End field. #294 (comment)
I didn't want it to be removed; I wanted End to change to *int and get omitempty. Begin was supposed to stay the way it was.
|
This will need to be rebased to handle the API change in #295 |
|
new PR #298 |
3 participants
A compliant report need to output lines on "location" object to work properly as doc in link show us: https://docs.gitlab.com/ci/testing/code_quality/
This commit write de "lines" property properly. If "location" object don't output the line, the gitlab show a message saying "Failed to load Code Quality report"