Adds support for DSLX bit vectors wider than 64 bits in the C++ transpiler. #3766
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_862902415
branch
4 times, most recently
from
3b6aaf9 to
6811a1d
Compare
copybara-service
bot
force-pushed
the
test_862902415
branch
from
6811a1d to
1898ab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for DSLX bit vectors wider than 64 bits in the C++ transpiler.
Previously, bit vectors larger than 64 bits were incorrectly represented as
(u)int64_t. This change introduces a new representation for wide bit vectors:std::bitset<N>.A new class hierarchy is introduced:
BitVectorCppEmitter: Base class for bit vector emitters.CppIntBitVectorEmitter: Handles bit vectors up to 64 bits, using standard C++ integer types.RawBitVectorCppEmitter: Handles bit vectors larger than 64 bits, usingstd::bitset<N>.Enums are a special case; their underlying type is capped at 64 bits in the C++ representation, even if the DSLX type is wider.
Helper functions
FillBitSetandFromBitSetare added toxls::Bitsto facilitate conversion betweenBitsandstd::bitset<N>.Fixes: #1135
Bug: #3764
Bug: #3763