[opt] Simplify or_reduce(neg(x)) => or_reduce(x)
#3639
+42
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a strict local improvement (
or_reduce(neg(x))depends onxinstead ofneg(x))However, it also highlights an existing representational redundancy: for bits values,
or_reduce(x)andne(x, 0)both meanx != 0and we don’t currently canonicalize between them. We may want to decide on a canonical nez form, or make some query helpers that recognize both as equivalent representations, but I think best done in a follow-up after some discussion, rather than as part of this change.