[codegen 1.5] Update idle signal generation to account for active I/O handshakes. #3629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handshakes. The idle signal now goes low not only when data is moving through the pipeline stages but also when input or output flops are actively completing a ready/valid handshake. This includes cases where function inputs are flopped or when flopped channels are completing a transaction. This lets us correctly enable some idle-signal block conversion tests after updating their expectations. PiperOrigin-RevId: 850162851
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[codegen 1.5] Update idle signal generation to account for active I/O handshakes.
The idle signal now goes low not only when data is moving through the pipeline stages but also when input or output flops are actively completing a ready/valid handshake. This includes cases where function inputs are flopped or when flopped channels are completing a transaction.
This lets us correctly enable some idle-signal block conversion tests after updating their expectations.