Convert more files from java to kotlin #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucianbc
force-pushed
the
more-java-to-kt
branch
from
bd06238 to
ea3c964
Compare
lucianbc
force-pushed
the
more-java-to-kt
branch
from
ea3c964 to
e441fec
Compare
artrointel
reviewed
Oct 3, 2025
| internal object TestResultFormatter { | ||
| @JvmStatic | ||
| fun formatSuccess(successMessage: String): String { | ||
| return "[MEMORY_FOOTPRINT]: ✅PASS✅ $successMessage ✅ " |
There was a problem hiding this comment.
Nice touch adding the emoji for clarity! One small concern is that emojis might not render consistently across all environments (encoding, terminals, IDEs). To keep things universally compatible, maybe we could stick to plain ASCII symbols like !, or x instead.
| String.format("Cannot extract User Configuration child from %s", node.nodeName) | ||
| ) | ||
| } | ||
| for (i in 0 until node.childNodes.length) { |
There was a problem hiding this comment.
It might look cleaner to add an extension function like
fun NodeList.asList(): List<Node> =
(0 until this.length).map { this.item(it) }Then this part could be simplified to
return node.childNodes
.asList()
.firstOrNull { it.attributes?.getNamedItem("id")?.nodeValue == configValueId }
?.let { Optional.of(it) }
?: Optional.empty()This would make the code a bit more concise and Kotlin-idiomatic.
garanj
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert a few easy files from java to kotlin