-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Update Swift versions #14342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update Swift versions #14342
Conversation
|
FranzBusch is a new contributor to projects/swift-nio. The PR must be approved by known contributors before it can be merged. The past contributors are: catenacyber, asraa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This overall looks good. There's a current issue which caused the ubuntu* base images not to be pushed to the registry #14338 which has just been fixed #14340 Will wait for the base images to be propagated to test this (in 24h or so) and then merge this PR.
Edit: can see they've already been pushed actually.
|
IIUC, the |
b689cbe to
dd6f08a
Compare
Updates the Swift version to the latest released Swift version. This ensures that the projects are fuzzed against the latest compiler and runtime versions. Additionally, some projects don't support 5.10 anymore so bumping to 6.2 should give us the latest versions of those projects.
Co-authored-by: Kleis Auke Wolthuizen <[email protected]>
dd6f08a to
4f968e1
Compare
|
@kleisauke Sorry it took me a bit to get back to this. I updated the |
|
/gcbrun trial_build.py swift-nio swift-protobuf grpc-swift --force-build |
|
@DavidKorczynski thanks for kicking the build. It looks like the Swift deps weren't correct and I just updated that. Can you kick the build again? |
|
/gcbrun trial_build.py swift-nio swift-protobuf grpc-swift --force-build |
|
The plan now is to land #14486 and then follow the steps Thomas mentions here #14486 (comment) "land this and then stack #14342 on top, and thus move both of your base images forward, just to different Swift versions.". Thomas has a point on making sure 20.04 follows |
I may go back on this and simply go through with this PR. We have so few swift projects and think we can look beyond 20.04. For that reason if we can get the CI working here then we should just land this. |
|
/gcbrun trial_build.py swift-nio swift-protobuf grpc-swift --force-build |
|
Thanks for pushing on this @DavidKorczynski. It is not entirely clear to me why the trial build failed. |
|
This looks to be failing: |
|
Hm weird since I added |
|
@DavidKorczynski I am confused why this not picking up my changes in |
hmm, let me run this locally and see if I run into the same issue |
|
Did this succeed for you locally @FranzBusch ? When I try to build it I get the error: You can try to build the images by using the below changes in |
Updates the Swift version to the latest released Swift version. This ensures that the projects are fuzzed against the latest compiler and runtime versions. Additionally, some projects don't support 5.10 anymore so bumping to 6.2 should give us the latest versions of those projects.