-
Notifications
You must be signed in to change notification settings - Fork 295
Add console user update and minor fixes to delete #2610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gbrodman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ptkach)
3275f99 to
8f7e666
Compare
gbrodman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 11 files at r2, all commit messages.
Reviewable status: 10 of 12 files reviewed, 1 unresolved discussion (waiting on @ptkach)
core/src/main/java/google/registry/ui/server/console/ConsoleUsersAction.java line 272 at r2 (raw file):
public record UserData( @Expose String emailAddress, @Expose String role, @Expose @Nullable String password) {}
I think this probably doesn't quite match the paradigm that we want of multi-accreditation, AKA "one login can have permissions to multiple registrar objects, with potentially different roles on each of them". Thoughts?
ptkach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 10 of 12 files reviewed, 1 unresolved discussion (waiting on @gbrodman)
core/src/main/java/google/registry/ui/server/console/ConsoleUsersAction.java line 272 at r2 (raw file):
Previously, gbrodman wrote…
I think this probably doesn't quite match the paradigm that we want of multi-accreditation, AKA "one login can have permissions to multiple registrar objects, with potentially different roles on each of them". Thoughts?
What I have doesn't prevent multi-accreditation. I will add it on top of what I have as a part of future update
gbrodman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 10 of 12 files reviewed, all discussions resolved
core/src/main/java/google/registry/ui/server/console/ConsoleUsersAction.java line 272 at r2 (raw file):
Previously, ptkach (Pavlo Tkach) wrote…
What I have doesn't prevent multi-accreditation. I will add it on top of what I have as a part of future update
synced up offline-- we'll follow up on this later
This change is