Skip to content

Conversation

@ptkach
Copy link
Collaborator

@ptkach ptkach commented Nov 13, 2024

This change is Reviewable

@ptkach ptkach requested a review from gbrodman November 13, 2024 21:26
Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ptkach)

@ptkach ptkach force-pushed the consoleUsersDeleteFix branch from 3275f99 to 8f7e666 Compare November 14, 2024 21:49
@ptkach ptkach changed the title Add minor fixes to console users delete Add console user update and minor fixes to delete Nov 14, 2024
Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 11 files at r2, all commit messages.
Reviewable status: 10 of 12 files reviewed, 1 unresolved discussion (waiting on @ptkach)


core/src/main/java/google/registry/ui/server/console/ConsoleUsersAction.java line 272 at r2 (raw file):

  public record UserData(
      @Expose String emailAddress, @Expose String role, @Expose @Nullable String password) {}

I think this probably doesn't quite match the paradigm that we want of multi-accreditation, AKA "one login can have permissions to multiple registrar objects, with potentially different roles on each of them". Thoughts?

Copy link
Collaborator Author

@ptkach ptkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 10 of 12 files reviewed, 1 unresolved discussion (waiting on @gbrodman)


core/src/main/java/google/registry/ui/server/console/ConsoleUsersAction.java line 272 at r2 (raw file):

Previously, gbrodman wrote…

I think this probably doesn't quite match the paradigm that we want of multi-accreditation, AKA "one login can have permissions to multiple registrar objects, with potentially different roles on each of them". Thoughts?

What I have doesn't prevent multi-accreditation. I will add it on top of what I have as a part of future update

Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 10 of 12 files reviewed, all discussions resolved


core/src/main/java/google/registry/ui/server/console/ConsoleUsersAction.java line 272 at r2 (raw file):

Previously, ptkach (Pavlo Tkach) wrote…

What I have doesn't prevent multi-accreditation. I will add it on top of what I have as a part of future update

synced up offline-- we'll follow up on this later

@ptkach ptkach added this pull request to the merge queue Nov 15, 2024
Merged via the queue into google:master with commit eeed166 Nov 15, 2024
6 checks passed
@ptkach ptkach deleted the consoleUsersDeleteFix branch November 15, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants