Fixed unreachable option in re2.#165
Fixed unreachable option in re2.#165hghwng wants to merge 1 commit intogoogle:masterfrom hghwng:patch-1
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Any update? |
|
Fun, good catch! |
data[0] << 16 + data[1]always results in0b0000_0000_XXXX_XXXX, whereXXXX_XXXXis the bits ofdata[1]. Therefore,f & 256tof & 1024are meaningless.