Skip to content

Conversation

@kuraun
Copy link

@kuraun kuraun commented Jun 9, 2021

  • Add MetadataKey "prefix" and "suffix" of LogContext
  • Modify to generate LogMessageFormatter using MetaData

Related: #275

- Add MetadataKey "prefix" and "suffix" of LogContext
- Modify to generate LogMessageFormatter using MetaData
@google-cla
Copy link

google-cla bot commented Jun 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 9, 2021
@kuraun
Copy link
Author

kuraun commented Jun 9, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 9, 2021
@kluever kluever requested a review from cgdecker June 11, 2021 14:37
@kluever kluever added P3 type=enhancement Make an existing feature better labels Jun 11, 2021
@sebastienvermeille
Copy link

Would be a great improvement do we have any news regarding it ?

Thank you

@hagbard
Copy link
Contributor

hagbard commented Nov 4, 2021

The right way to fix this is to open-source the customizable message formatter we currently use internally. This allows more customization than just changing the suffix/prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes P3 type=enhancement Make an existing feature better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants