Load cc_library and cc_test from rules_cc #269
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the current recommended best-practice. In the next release of bazel, it will no longer be allowed to use the cc_* targets which were previously built into the bazel binary. rules_cc must be used going forward.
This PR fixes the build with bazel rolling release in the bazel-central-registry CI.
For an example of the current failure, see:
https://buildkite.com/bazel/bcr-presubmit/builds/25936/steps/canvas?jid=019bb98a-07bb-4220-a0ea-c7950c477cea#019bb98a-07bb-4220-a0ea-c7950c477cea/L312
I also went ahead and bumped the version to 3.4.1 in the MODULE.bazel file. I would be very grateful if you would be willing to cut a new patch release with this fix, and publish it to the BCR. Then I can depend on it in folly and re-enable testing with the bazel rolling release in CI.