Copy fuzzer script logs to correct buckets #5099
Conversation
javanlacerda
left a comment
javanlacerda
left a comment
There was a problem hiding this comment.
LGTM, just some nits. Thanks for fixing it.
| fuzzer_logs_bucket = fuzzer_logs.get_logs_gcs_path() | ||
| try: | ||
| if not storage.copy_blob(logs_blob_bucket, fuzzer_logs_bucket): | ||
| logs.warning( |
There was a problem hiding this comment.
Maybe just run Raise here to avoid duplicate the warning?
There was a problem hiding this comment.
I didn't want to break the fuzz task postprocess if this copy operation fails, as it is not critical. So I'd rather not raise the exception here.
I could get the return of the copy_blob and add a finally block to log warning for both cases and avoid duplicate the warning, but tbh I'm ok with the as is.
There was a problem hiding this comment.
But you're catching the exception in the line 808, so if you raise, it will send the warning and continue
There was a problem hiding this comment.
Ah I see what you meant, yeah I can do that. Thanks
2 participants
Handler for
store_fuzzer_run_resultsin postprocess (#3406) was not adding the fuzzer script logs to the correct structured buckets, as expected by the fuzzer page on the UI. This PR tries to fix it by copying the data from the blob store to the expected buckets during postprocess.b/361867455