Download databundles for non engine jobs #5085
Conversation
…er download - Add `web_tests_url` field to `FuzzTaskInput` proto. - Sign `WEB_TESTS_URL` in `fuzz_task.py` preprocess and pass it to `utask_main`. - In `utask_main`, call `update_tests_if_needed` with the signed URL. - Update `update_tests_if_needed` in `update_task.py` to accept `tests_url`. - Use `archive.HttpZipFile` for streaming extraction of the signed URL if compatible, avoiding large file download to disk. - Recompile `uworker_msg.proto`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
- Add `web_tests_url` to `FuzzTaskInput` proto and recompile. - Sign `WEB_TESTS_URL` in `fuzz_task` preprocess. - In `utask_main`, if blackbox fuzzing, pass signed URL to `update_tests_if_needed`. - In `update_tests_if_needed`, handle signed URL (downloading to file if http). - Use `unzip -q` for extraction if available for speed, falling back to `archive` module. - Refactor defensive checks in `fuzz_task`.
- Add `web_tests_url` to `FuzzTaskInput` proto and recompile. - Sign `WEB_TESTS_URL` in `fuzz_task` preprocess. - In `utask_main`, if blackbox fuzzing, pass signed URL to `update_tests_if_needed`. - In `update_tests_if_needed`, handle signed URL (downloading to file if http). - Use `unzip -q` via `subprocess` for extraction if available for speed, falling back to `archive` module. - Refactor defensive checks in `fuzz_task`.
|
/gcbrun |
Added copyright notice and licensing information.
|
/gcburn |
|
/gcbrun |
jonathanmetzman
changed the title
|
/gcbrun |
|
Where is the |
I think it's in clusterfuzz-confgi |
That's correct. It is retrieved from the environment variables ( |
jonathanmetzman
deleted the
signed-web-tests-url-download-12488238925609698644
branch
2 participants
This fixes b/446692241 by downloading databundles on blacbox fuzzer runs.
It does so without hurting the performance of non-blackbox batch tasks. Since downloading the default databundle takes ~5 minutes. It also optimizes the unzip by about 50% by using the linux unzip binary instead of Python's slow implementation.