-
Notifications
You must be signed in to change notification settings - Fork 594
Reduce docker image size by cleaning up ruby install artifacts #5084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Reduce docker image size by cleaning up ruby install artifacts #5084
Conversation
Added cleanup steps to remove the ruby source directory and tarball after installation in: - docker/base/Dockerfile - docker/base/ubuntu-20-04.Dockerfile - docker/base/ubuntu-24-04.Dockerfile This will reduce the final image size.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
/gcbrun |
|
@matheus btw, why do we have a Dockerfile and a ubuntu20-04.Dockerfile? They are doing the same thing right? |
Added cleanup steps to remove the ruby source directory and tarball after installation in: - docker/base/Dockerfile - docker/base/ubuntu-20-04.Dockerfile - docker/base/ubuntu-24-04.Dockerfile This will reduce the final image size.
- Clean up ruby installation artifacts in base dockerfiles. - Ensure `apt-get update` is run before installation steps to fix build failures. - Fix potential apt cache issues in `docker/chromium/base/ubuntu-24-04.Dockerfile`.
|
/gcburn |
- Clean up ruby installation artifacts in base dockerfiles. - Ensure `apt-get update` is run before installation steps to fix build failures. - Fix potential apt cache issues in `docker/chromium/base/ubuntu-24-04.Dockerfile`.
|
Something is off about CI here that I'm pretty sure is unrelated to this PR |
- Clean up ruby installation artifacts in base dockerfiles. - Ensure `apt-get update` is run before installation steps to fix build failures. - Fix potential apt cache issues in `docker/chromium/base/ubuntu-24-04.Dockerfile`.
|
/gcbrun |
- Clean up ruby installation artifacts in base dockerfiles. - Ensure `apt-get update` is run before installation steps to fix build failures. - Fix potential apt cache issues in `docker/chromium/base/ubuntu-24-04.Dockerfile`.
|
/gcbrun |
|
/gcbrun |
- Clean up ruby installation artifacts in base dockerfiles. - Ensure `apt-get update` is run before installation steps to fix build failures. - Fix potential apt cache issues in `docker/chromium/base/ubuntu-24-04.Dockerfile`.
|
/gcbrun |
This change reduces the size of the docker images by removing the ruby source directory and tarball after installation. This is applied to
docker/base/Dockerfile,docker/base/ubuntu-20-04.Dockerfile, anddocker/base/ubuntu-24-04.Dockerfile. It reduces it by almost 1 GB unpacked.PR created automatically by Jules for task 17846647314772110864 started by @jonathanmetzman