Skip to content

Conversation

@qyeo-sc
Copy link
Contributor

@qyeo-sc qyeo-sc commented Dec 9, 2025

There are two issues that this PR fixes:

  1. When self.client.add_watcher(issue.jira_issue, watcher) fails previously, it'd throw an exception resulting in the entire .save or .create call to fail, which would retry continuously hammering the jira instance.
  2. The function would always try to add watchers to issues regardless if the watchers were already added previously.

@qyeo-sc
Copy link
Contributor Author

qyeo-sc commented Dec 9, 2025

@jonathanmetzman would you be able to take a look whenever you have the time?

Copy link
Contributor

@javanlacerda javanlacerda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any unit tests that can be added ?

@qyeo-sc
Copy link
Contributor Author

qyeo-sc commented Dec 9, 2025

Is there any unit tests that can be added ?

@javanlacerda added some unit tests here

@qyeo-sc qyeo-sc requested a review from javanlacerda December 11, 2025 20:49
@qyeo-sc
Copy link
Contributor Author

qyeo-sc commented Dec 16, 2025

@javanlacerda could you take another look whenever you have the chance?

@qyeo-sc
Copy link
Contributor Author

qyeo-sc commented Dec 23, 2025

@decoNR @javanlacerda

Could we make some progress on this PR? Happy to make any changes if needed.

Seems like we need a /gcbrun to run the unit tests.

Thank you and happy holidays.

@jonathanmetzman
Copy link
Collaborator

/gcbrun

@qyeo-sc
Copy link
Contributor Author

qyeo-sc commented Dec 23, 2025

Thanks @jonathanmetzman, I fixed the lint issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants