Handle disfunctional issue handlers properly in triage #4476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorguidi
changed the title
This reverts commit 64470a0.
vitorguidi
changed the title
vitorguidi
commented
Dec 9, 2024
| # If this project does not have an associated issue tracker, we cannot | ||
| # file this crash anywhere. | ||
| issue_tracker = issue_tracker_utils.get_issue_tracker_for_testcase(testcase) | ||
| try: |
Contributor
Author
There was a problem hiding this comment.
This is the part that solves the incident, along deleting the config
@jonathanmetzman
| testcase.delete_metadata(TRIAGE_MESSAGE_KEY, update_testcase=False) | ||
|
|
||
| # File the bug first and then create filed bug metadata. | ||
| # # File the bug first and then create filed bug metadata. |
vitorguidi
added a commit
that referenced
this pull request
Dec 20, 2024
Fuchsia testcases were referencing monorail, for which the API was deprecated. This implied on the cronjob failing prematurely, and no issues being filed on google3. This PR adds extra logging, so we can troubleshoot this sort of issue more easily. Also, under the triage cronjob, the ValueError exception is handled, to handle gracefully the case where some testcase references an issue finder that is not present under the issue tracker config.
jonathanmetzman
pushed a commit
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fuchsia testcases were referencing monorail, for which the API was deprecated. This implied on the cronjob failing prematurely, and no issues being filed on google3.
This PR adds extra logging, so we can troubleshoot this sort of issue more easily.
Also, under the triage cronjob, the ValueError exception is handled, to handle gracefully the case where some testcase references an issue finder that is not present under the issue tracker config.