Skip to content

build_manager: allow remote unpacking when unpacking everything #4473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanmetzman merged 1 commit into from
Dec 9, 2024
Merged

build_manager: allow remote unpacking when unpacking everything #4473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/clusterfuzz/_internal/build_management/build_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,12 +485,11 @@ def _open_build_archive(self, base_build_dir: str, build_dir: str,
# if the HTTP URL is compatible with remote unzipping.
allow_unpack_over_http = environment.get_value(
'ALLOW_UNPACK_OVER_HTTP', default_value=False)
can_unzip_over_http = (
allow_unpack_over_http and not self._unpack_everything and
http_build_url and
can_unpack_over_http = (
allow_unpack_over_http and http_build_url and
build_archive.unzip_over_http_compatible(http_build_url))

if not can_unzip_over_http:
if not can_unpack_over_http:
return self._download_and_open_build_archive(base_build_dir, build_dir,
build_url)
# We do not emmit a metric for build download time, if using http
Expand Down