Skip to content

fix: prevent path traversal in remote file synchronization #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
g0w6y wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent path traversal in remote file synchronization #1109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/core/files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,19 @@ export class Files {
debug('Fetching script content, request %o', requestOptions);
const response = await script.projects.getContent(requestOptions);
const files = response.data.files ?? [];

const absoluteContentDir = path.resolve(contentDir);

return files.map(f => {
const ext = getFileExtension(f.type, fileExtensionMap);
const localPath = path.relative(process.cwd(), path.resolve(contentDir, `${f.name}${ext}`));
const resolvedPath = path.resolve(contentDir, `${f.name}${ext}`);

// SECURITY CHECK: Ensure the resolved path remains inside the absoluteContentDir
if (!resolvedPath.startsWith(absoluteContentDir + path.sep) && resolvedPath !== absoluteContentDir) {
throw new Error(`Security Error: Remote file name "${f.name}" attempts to write outside the project directory.`);
}

const localPath = path.relative(process.cwd(), resolvedPath);

const file = {
localPath: localPath,
Expand Down Expand Up @@ -570,3 +580,4 @@ function extractSyntaxError(error: GaxiosError, files: ProjectFile[]) {
snippet = preLines + '\n' + errLine + '\n' + postLines;
return {message, snippet}; // Return the formatted message and snippet.
}