Add map library with merge functionality#1239
Open
gfrey wants to merge 1 commit intogoogle:masterfrom
Open
Conversation
Allows to merge two maps. Maps must have identical value types. Keys of the second map take precedence.
Collaborator
|
/gcbrun |
|
Hey @TristonianJones - this PR was originally opened against kubernetes-sigs/kro code base and we advised to contribute to upstream cel-go instead. Do you think this is something you're interested in taking? :) |
Collaborator
|
@a-hilaly thanks for the referral. I think we just need to consider how best to make this approach work for a variety of types and a variety of merge heuristics. Definitely interested though. |
|
Any updates on getting this feature merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to merge two maps. Maps must have identical value types. Keys of the second map take precedence.
I initially wrote this library for kro (see kubernetes-sigs/kro#628), but was asked to contribute it here.
Pull Requests Guidelines
See CONTRIBUTING.md for more details about when to create
a GitHub Pull Request and when other kinds of contributions or
consultation might be more desirable.
When creating a new pull request, please fork the repo and work within a
development branch.
Commit Messages
Reviews
Merging
they have write access. Otherwise, the change will be merged by a maintainer.
closes #<issue-num>: descriptionin the merge message,if applicable.