java: add explicit null check in BrotliInputStream.read #1413
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: BrotliInputStream.read(byte[], int, int) currently dereferences destBuffer.length during bounds checking, so passing a null buffer triggers a NullPointerException from the dereference rather than an explicit parameter check.
Why change: InputStream.read(byte[], int, int) specifies NullPointerException when the buffer argument is null, so this change preserves the expected exception type while making the failure mode explicit and easier to diagnose.
Repro: