Select emulated camera apex via assemble_cvd.#2295
Open
ser-io wants to merge 2 commits intogoogle:mainfrom
Open
Select emulated camera apex via assemble_cvd.#2295ser-io wants to merge 2 commits intogoogle:mainfrom
ser-io wants to merge 2 commits intogoogle:mainfrom
Conversation
jmacnak
approved these changes
Mar 20, 2026
Databean
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
auto-merge was automatically disabled
March 23, 2026 17:11
Pull request was converted to draft
ser-io
force-pushed
the
apex-select
branch
2 times, most recently
from
41d8e97 to
15d81a7
Compare
Pass builtin bootconfig args to the logic of building the bootconfig args at launch time to avoid kernel error: ``` Failed to parse bootconfig: Value is redefined at XXX. ``` Create new library to resolve cyclic dependency scenario. Bug: 485605842
Bug: 485605842
Databean
reviewed
Mar 23, 2026
Comment on lines
+47
to
+50
| CF_EXPECT(UnpackVendorBootImageIfNotUnpacked(instance.vendor_boot_image(), tmpdir), | ||
| "Failed to extract the vendor boot image"); | ||
| std::unordered_map<std::string, std::string> args; | ||
| std::string content = ReadFile(tmpdir + "/bootconfig"); |
Member
There was a problem hiding this comment.
Rather than use UnpackVendorBootImageIfNotUnpacked, can this use
VendorBootImage::ReadVendorBootImage::BootConfig()ReadToString(Reader)
That avoids having to go through creating new files in /tmp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.