Skip to content

fix(models): register gemma 4 model names #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pandego wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

fix(models): register gemma 4 model names #5158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/google/adk/models/gemma_llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def supported_models(cls) -> list[str]:
"""

return [
r'gemma-3.*',
r'gemma-.*',
]

@cached_property
Expand Down
14 changes: 14 additions & 0 deletions tests/unittests/models/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

from google.adk import models
from google.adk.models.anthropic_llm import Claude
from google.adk.models.gemma_llm import Gemma
from google.adk.models.google_llm import Gemini
from google.adk.models.lite_llm import LiteLlm
import pytest
Expand Down Expand Up @@ -56,6 +57,19 @@ def test_match_claude_family(model_name):
assert models.LLMRegistry.resolve(model_name) is Claude


@pytest.mark.parametrize(
'model_name',
[
'gemma-3-27b-it',
'gemma-4-27b-it',
'gemma-4-31b-it',
],
)
def test_match_gemma_family(model_name):
"""Test that Gemma models are resolved correctly."""
assert models.LLMRegistry.resolve(model_name) is Gemma


@pytest.mark.parametrize(
'model_name',
[
Expand Down