docs: add guide for MCP Apps integration in A2UI surface#995
docs: add guide for MCP Apps integration in A2UI surface#995sugoi-yuzuru merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new guide for MCP Apps integration in A2UI surfaces, detailing the double-iframe isolation pattern, security rationale, and providing usage examples and testing instructions. Feedback includes a suggestion to simplify the input binding logic in the documentation's code examples using the nullish coalescing operator and a recommendation to align the navigation title in mkdocs.yaml with the document's main heading for consistency.
| inputBinding( | ||
| 'content', | ||
| () => ('content' in properties && properties['content']) || undefined, | ||
| ), | ||
| inputBinding('title', () => ('title' in properties && properties['title']) || undefined), | ||
| ], | ||
| }, |
There was a problem hiding this comment.
The inputBinding logic for content and title can be simplified using the nullish coalescing operator (??). This improves readability and conciseness, and explicitly handles cases where the property might be null by converting it to undefined, aligning with common Angular input binding patterns.
For example, ('content' in properties && properties['content']) || undefined can be replaced with properties['content'] ?? undefined.
| inputBinding( | |
| 'content', | |
| () => ('content' in properties && properties['content']) || undefined, | |
| ), | |
| inputBinding('title', () => ('title' in properties && properties['title']) || undefined), | |
| ], | |
| }, | |
| inputBinding( | |
| 'content', | |
| () => properties['content'] ?? undefined, | |
| ), | |
| inputBinding('title', () => properties['title'] ?? undefined), |
| - Authoring Custom Components: guides/authoring-components.md | ||
| - Theming & Styling: guides/theming.md | ||
| - A2UI over MCP: guides/a2ui_over_mcp.md | ||
| - MCP Apps integration in A2UI Surface: guides/mcp-apps-in-a2ui-surface.md |
There was a problem hiding this comment.
The navigation entry title "MCP Apps integration in A2UI Surface" is inconsistent with the document's main heading "# MCP Apps Integration in A2UI Surfaces". For better consistency and user experience, it's recommended to align the navigation title with the document's actual title.
- MCP Apps Integration in A2UI Surfaces: guides/mcp-apps-in-a2ui-surface.md| - A2UI over MCP: guides/a2ui_over_mcp.md | ||
| - MCP Apps integration in A2UI Surface: guides/mcp-apps-in-a2ui-surface.md |
Description
Add a guide for MCP Apps integration into A2UI Surfaces.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.