-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(react,v0.9): Add markdown support via dependency injection to Text component #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jacobsimionato
wants to merge
6
commits into
google:main
Choose a base branch
from
jacobsimionato:react-markdown
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+272
−22
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bf02489
feat(react,v0.9): Add markdown support via dependency injection to Te…
jacobsimionato 77b6d0a
fix(react): resolve eslint floating promise and prettier errors
jacobsimionato 0d3c977
resolve comments
jacobsimionato 4c2297c
Fix demo
jacobsimionato 53a0808
Fix flashing
jacobsimionato 7b8c27a
ci(react): build markdown-it dependency before react demo
jacobsimionato File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /** | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import React, {createContext, useContext} from 'react'; | ||
| import {type MarkdownRenderer} from '@a2ui/web_core/v0_9'; | ||
|
|
||
| const MarkdownContext = createContext<MarkdownRenderer | undefined>(undefined); | ||
|
|
||
| export const MarkdownProvider: React.FC<{ | ||
| renderer?: MarkdownRenderer; | ||
| children: React.ReactNode; | ||
| }> = ({renderer, children}) => ( | ||
| <MarkdownContext.Provider value={renderer}>{children}</MarkdownContext.Provider> | ||
| ); | ||
jacobsimionato marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| export const useMarkdown = () => useContext(MarkdownContext); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /** | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { describe, it, expect, vi } from 'vitest'; | ||
| import { screen, waitFor } from '@testing-library/react'; | ||
| import { renderA2uiComponent } from '../utils'; | ||
| import { MarkdownProvider, Text } from '../../src/v0_9'; | ||
| import { type MarkdownRenderer } from '@a2ui/web_core/v0_9'; | ||
|
|
||
| describe('Markdown Rendering in React v0.9', () => { | ||
| it('renders plain text when no markdown renderer is provided', async () => { | ||
| renderA2uiComponent(Text, 't1', { text: '**Bold**' }); | ||
|
|
||
| // It should render the raw markdown string as plain text | ||
| expect(screen.getByText('**Bold**')).toBeDefined(); | ||
| }); | ||
|
|
||
| it('renders markdown when a renderer is provided via MarkdownProvider', async () => { | ||
| const mockRenderer: MarkdownRenderer = vi.fn().mockResolvedValue('<strong>Bold</strong>'); | ||
|
|
||
| renderA2uiComponent(Text, 't1', { text: '**Bold**' }, { | ||
| wrapper: ({ children }) => ( | ||
| <MarkdownProvider renderer={mockRenderer}> | ||
| {children} | ||
| </MarkdownProvider> | ||
| ) | ||
| }); | ||
|
|
||
| // Wait for the mock renderer to be called and state to update | ||
| await waitFor(() => expect(mockRenderer).toHaveBeenCalledWith('**Bold**')); | ||
|
|
||
| // Check for rendered HTML. dangerouslySetInnerHTML is used. | ||
| const element = screen.getByText('Bold'); | ||
| expect(element.tagName).toBe('STRONG'); | ||
| expect(element.parentElement?.tagName).toBe('SPAN'); // Default body variant is span | ||
| }); | ||
|
|
||
| it('renders with correct semantic wrapper and injected markdown', async () => { | ||
| const mockRenderer: MarkdownRenderer = vi.fn().mockResolvedValue('<u>Underline</u>'); | ||
|
|
||
| const { view } = renderA2uiComponent(Text, 't1', { text: 'text', variant: 'h2' }, { | ||
| wrapper: ({ children }) => ( | ||
| <MarkdownProvider renderer={mockRenderer}> | ||
| {children} | ||
| </MarkdownProvider> | ||
| ) | ||
| }); | ||
|
|
||
| await waitFor(() => { | ||
| const h2 = view.container.querySelector('h2'); | ||
| expect(h2).not.toBeNull(); | ||
| expect(h2?.innerHTML).toBe('<u>Underline</u>'); | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.