Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/composer_build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: Composer build and test
name: Composer

on:
push:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: Docs Build and Deploy
name: Docs

on:
push:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/editor_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: Editor build
name: Editor

on:
push:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/inspector_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: Inspector build
name: Inspector

on:
push:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/java_build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: Java sample build and test
name: Java sample

on:
push:
Expand Down
60 changes: 60 additions & 0 deletions .github/workflows/lit_build_and_test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

name: Lit renderer

on:
push:
branches: [ main ]
paths:
- 'renderers/lit/**'
- 'renderers/web_core/**'
- '.github/workflows/lit_build_and_test.yml'
pull_request:
paths:
- 'renderers/lit/**'
- 'renderers/web_core/**'
- '.github/workflows/lit_build_and_test.yml'

jobs:
build-and-test:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v6

- name: Set up Node.js
uses: actions/setup-node@v6
with:
node-version: '20'

- name: Install web_core dependencies
working-directory: ./renderers/web_core
run: npm i

- name: Build web_core
working-directory: ./renderers/web_core
run: npm run build

- name: Install Lit renderer dependencies
working-directory: ./renderers/lit
run: npm i

- name: Build Lit renderer
working-directory: ./renderers/lit
run: npm run build

- name: Run Lit renderer tests
working-directory: ./renderers/lit
run: npm test
2 changes: 1 addition & 1 deletion .github/workflows/lit_samples_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: Lit samples build
name: Lit samples

on:
push:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ng_build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: Angular build and test
name: Angular

on:
push:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python_agent_sdk_build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: Build and Test A2UI-agent Python SDK
name: A2UI-agent Python SDK

on:
push:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python_samples_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: Build python samples
name: Python samples

on:
push:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate_specifications.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: Validate A2UI Specification Examples
name: Validate A2UI specification examples

on:
push:
Expand Down
19 changes: 5 additions & 14 deletions .github/workflows/web_build_and_test.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2025 Google LLC
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -12,18 +12,16 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: Lit renderer build and test
name: Web core

on:
push:
branches: [ main ]
paths:
- 'renderers/lit/**'
- 'renderers/web_core/**'
- '.github/workflows/web_build_and_test.yml'
pull_request:
paths:
- 'renderers/lit/**'
- 'renderers/web_core/**'
- '.github/workflows/web_build_and_test.yml'

Expand All @@ -47,14 +45,7 @@ jobs:
working-directory: ./renderers/web_core
run: npm run build

- name: Install Lit renderer dependencies
working-directory: ./renderers/lit
run: npm i

- name: Build Lit renderer
working-directory: ./renderers/lit
run: npm run build
- name: Test web_core
working-directory: ./renderers/web_core
run: npm run test

- name: Run Lit renderer tests
working-directory: ./renderers/lit
run: npm test
2 changes: 1 addition & 1 deletion renderers/web_core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"clean": "if-file-deleted"
},
"test": {
"command": "node --test \"dist/**/*.test.js\"",
"command": "node --test dist",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The change to node --test dist addresses the issue of npm run test not working, which is a good fix. However, the test:coverage script (line 44) still uses the explicit glob pattern "dist/**/*.test.js".

For consistency and clarity in defining which files are considered tests, it would be beneficial to align these two commands. Consider either updating test:coverage to also use node --test dist (if c8 supports it and it correctly identifies all tests) or, if the glob pattern is preferred for its explicitness, investigate why node --test "dist/**/*.test.js" was not working previously and potentially re-introduce a working explicit pattern for both.

"dependencies": [
"build"
]
Expand Down
Loading