Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a version selection mechanism for A2UI extensions, which is a valuable improvement for ensuring forward compatibility. The refactoring across multiple agent examples to support this new mechanism is extensive. However, I've identified a few critical bugs in the sample agent implementations that would lead to runtime errors, as well as a high-severity issue in the core version selection logic that could cause incorrect behavior or crashes. Additionally, there's an opportunity to improve the consistency of the refactoring pattern applied across the different agents for better maintainability.
152619b to
d905d2e
Compare
gspencergoog
approved these changes
Mar 24, 2026
d905d2e to
6a7e01e
Compare
jacobsimionato
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.