Skip to content

A2ui extension selection#936

Merged
nan-yu merged 1 commit intogoogle:mainfrom
nan-yu:a2ui-extension-selection
Mar 25, 2026
Merged

A2ui extension selection#936
nan-yu merged 1 commit intogoogle:mainfrom
nan-yu:a2ui-extension-selection

Conversation

@nan-yu
Copy link
Copy Markdown
Collaborator

@nan-yu nan-yu commented Mar 23, 2026

Description

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a version selection mechanism for A2UI extensions, which is a valuable improvement for ensuring forward compatibility. The refactoring across multiple agent examples to support this new mechanism is extensive. However, I've identified a few critical bugs in the sample agent implementations that would lead to runtime errors, as well as a high-severity issue in the core version selection logic that could cause incorrect behavior or crashes. Additionally, there's an opportunity to improve the consistency of the refactoring pattern applied across the different agents for better maintainability.

@nan-yu nan-yu force-pushed the a2ui-extension-selection branch from 152619b to d905d2e Compare March 23, 2026 20:17
@nan-yu nan-yu force-pushed the a2ui-extension-selection branch from d905d2e to 6a7e01e Compare March 24, 2026 23:00
@nan-yu nan-yu merged commit 1e679fa into google:main Mar 25, 2026
11 checks passed
@nan-yu nan-yu deleted the a2ui-extension-selection branch March 25, 2026 00:20
@github-project-automation github-project-automation bot moved this from Todo to Done in A2UI Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants