Add Solarized Dark and Solarized Light themes

[rmedranollamas]

Summary

Add Solarized themes to built-in.

Details

Solarized is a super-popular theme set, adding as per popular demand.

Related Issues

Closes #19063

How to Validate

/theme -> Solarized Light / Dark

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @rmedranollamas, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience by incorporating the highly requested Solarized Dark and Solarized Light themes into the CLI. This addition provides users with more aesthetic choices, aligning with popular demand and enriching the visual customization capabilities of the application.

Highlights

• New Themes Added: Introduced 'Solarized Dark' and 'Solarized Light' themes to the CLI, expanding user customization options.
• Documentation Update: Updated the themes documentation to include the new Solarized themes and their corresponding screenshots.
• Theme Integration: Integrated the new Solarized themes into the theme manager for selection and application.

Changelog

• docs/cli/themes.md
  • Added 'Solarized Dark' to the list of dark themes.
  • Added 'Solarized Light' to the list of light themes.
  • Included a new section with a screenshot for 'Solarized Dark'.
  • Included a new section with a screenshot for 'Solarized Light'.
• packages/cli/src/ui/themes/solarized-dark.ts
  • Added a new file defining the 'Solarized Dark' theme, including its color palette and semantic color mappings.
• packages/cli/src/ui/themes/solarized-light.ts
  • Added a new file defining the 'Solarized Light' theme, including its color palette and semantic color mappings.
• packages/cli/src/ui/themes/theme-manager.ts
  • Imported 'SolarizedDark' and 'SolarizedLight' theme modules.
  • Registered 'SolarizedDark' and 'SolarizedLight' themes within the ThemeManager's list of available themes.

Activity

• The pull request was created by rmedranollamas to add Solarized themes.
• The author updated relevant documentation and added/updated tests as part of the pre-merge checklist.
• The changes were validated on MacOS using 'npm run' and on Linux using 'npm run'.
• This pull request addresses and closes issue Solarized Theme #19063.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the popular Solarized Dark and Solarized Light themes. The implementation is mostly correct, but I've found critical readability issues with the background colors used for diffs in highlighted code blocks for both themes. The chosen background colors result in very low text contrast. My review includes suggestions to fix these issues by using more appropriate background colors for added and deleted lines, which will significantly improve usability. The rest of the changes, including documentation updates and theme registration, look good.