Revert "Add generic searchable list to back settings and extensions"

[chrstnb]

Reverts #18838

[gemini-code-assist]

Summary of Changes

Hello @chrstnb, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a complete revert of a previous change that aimed to introduce a generic searchable list component. The revert removes all associated code, effectively eliminating the fuzzy search capabilities and the SearchableList component from the application, restoring the settings dialog to its prior state.

Highlights

• Reverted Searchable List Feature: The pull request fully reverts the functionality that introduced a generic searchable list component and its integration into the settings and extensions dialogs.
• Removed Fuzzy Search Logic: All code related to fuzzy search, including the AsyncFzf library integration, search state management, and filtering logic, has been removed from the settings dialog.
• Deleted Associated Files: The SearchableList component, its dedicated test file, and the useFuzzyList custom hook have all been removed from the codebase.

Changelog

• packages/cli/src/ui/components/SettingsDialog.tsx
  • Removed imports for AsyncFzf, useUIState, useTextBuffer, and FzfResult interface.
  • Removed search state management, fuzzy search logic, and related UI calculations.
  • Removed the useFuzzyList hook integration and adjusted props passed to BaseSettingsDialog.
• packages/cli/src/ui/components/shared/BaseSettingsDialog.tsx
  • Refactored item selection and scroll offset logic to simplify conditional checks.
  • Simplified useKeypress options by removing the priority property.
• packages/cli/src/ui/components/shared/SearchableList.test.tsx
  • Removed the test file for the SearchableList component.
• packages/cli/src/ui/components/shared/SearchableList.tsx
  • Removed the SearchableList component entirely.
• packages/cli/src/ui/hooks/useFuzzyList.ts
  • Removed the useFuzzyList custom hook entirely.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: +18.3 kB (+0.07%)

Total Size: 24.4 MB

Filename	Size	Change
./bundle/gemini.js	24.4 MB	+18.3 kB (+0.07%)

ℹ️ View Unchanged

Filename	Size
./bundle/sandbox-macos-permissive-open.sb	890 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB
./bundle/sandbox-macos-strict-open.sb	4.82 kB
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request reverts the generic searchable list abstraction and restores the search logic directly within the SettingsDialog component. While the revert aims to restore previous functionality, it introduces a few regressions in robustness and edge-case handling, particularly regarding error handling in asynchronous search operations and viewport width calculations on small terminals. The use of magic numbers in layout calculations should also be addressed for better maintainability.

[gemini-code-assist]

The asynchronous search operation lacks error handling. If fzfInstance.find fails (e.g., due to an internal worker error), the search will fail silently, leaving the filtered list in a stale state. It is recommended to add a .catch() block to handle potential rejections and reset the filtered keys to a safe default.

Suggested change

	const doSearch = async () => {
	const results = await fzfInstance.find(searchQuery);
	if (!active) return;
	const matchedKeys = new Set<string>();
	results.forEach((res: FzfResult) => {
	const key = searchMap.get(res.item.toLowerCase());
	if (key) matchedKeys.add(key);
	});
	setFilteredKeys(Array.from(matchedKeys));
	};
	// eslint-disable-next-line @typescript-eslint/no-floating-promises
	doSearch();
	const doSearch = async () => {
	try {
	const results = await fzfInstance.find(searchQuery);
	if (!active) return;
	const matchedKeys = new Set<string>();
	results.forEach((res: FzfResult) => {
	const key = searchMap.get(res.item.toLowerCase());
	if (key) matchedKeys.add(key);
	});
	setFilteredKeys(Array.from(matchedKeys));
	} catch (error) {
	setFilteredKeys(getDialogSettingKeys());
	}
	};