feat: add Type hints for examples/keras_api_example.py#131
feat: add Type hints for examples/keras_api_example.py#131Neerajpathak07 wants to merge 6 commits intogoogle-deepmind:mainfrom
examples/keras_api_example.py#131Conversation
| else: | ||
| print("Non-DP training") | ||
| model.compile( | ||
| loss="categorical_crossentropy", optimizer="adam", metrics=["accuracy"] |
There was a problem hiding this comment.
Is lint complaining about this? If this fits under the line limit then I'd reverse this change
There was a problem hiding this comment.
Ran this locally and at the upstream CI for lint turns out it runs clean so no need to change this.
…into type-hints-keras_api_example
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage ? 71.67%
=======================================
Files ? 25
Lines ? 2655
Branches ? 0
=======================================
Hits ? 1903
Misses ? 752
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…into type-hints-keras_api_example
|
@ryan112358 Have updated the import orders on these as well. |
Resolves #124
This PR adds a type hint for the examples file
keras_api_example.py.Optimizing the function from:-
to:-