fix: typos and stale TODO in _einsum_utils.py#593
Open
stanley1208 wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
fix: typos and stale TODO in _einsum_utils.py#593stanley1208 wants to merge 1 commit intogoogle-deepmind:mainfrom
stanley1208 wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
Fix 'reqrites' -> 'rewrites', 'a einsum' -> 'an einsum', 'elipsis' -> 'ellipsis', 'This assume' -> 'This assumes'. Remove stale TODO about length checking (_check_len2 already handles it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix typos and remove a stale TODO in
gemma/peft/_einsum_utils.py.Changes
"reqrites a einsum"→"rewrites an einsum"(line 31)"This assume there's no elipsis"→"This assumes there's no ellipsis"(line 69)TODO(epot): Check length—_check_len2already validates the split resultsTest plan
_einsum_utils_test.pypasses