test: add missing unit tests for untested modules#586
Open
irhyl wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
test: add missing unit tests for untested modules#586irhyl wants to merge 1 commit intogoogle-deepmind:mainfrom
irhyl wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
Add tests for modules that previously had zero test coverage: - gemma/gm/losses/_dpo_test.py: DPO loss shape, non-negativity, label smoothing - gemma/gm/losses/_npo_test.py: NPO loss shape, non-negativity, tau scaling - gemma/gm/ckpts/_paths_test.py: CheckpointPath enum validation, naming conventions - gemma/gm/math/_pos_utils_test.py: build_positions_from_mask correctness - gemma/gm/utils/_py_test.py: FrozenDataclass equality, hashing, sets/dicts - gemma/gm/tools/_manager_test.py: ToolHandlerBase context manager, _normalize_response - gemma/gm/data/_tasks_test.py: _decode_bytes helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for modules that previously had zero test coverage: