Broken error messages in token normalization—{token!r} shown literally instead of actual token value (#579)#580
Open
markknoffler wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #579
Root cause
In
_normalize_token, when astop_tokenorforbidden_tokenstring maps to multiple token IDs, the code raises aValueErrorusing a plain string instead of an f-string:Because there is no
fprefix, Python treats{token!r}as literal text. Users see:instead of the actual invalid token value, making debugging harder.
Fix summary
Use an f-string so
{token!r}is interpolated and the real token value appears in the error message. Apply the same change in both affected files.Patch sketch
1.
gemma/gm/text/_sampler.py2.
gemma/research/t5gemma/sampling.py