Fix : division by zero in sampling when temperature is 0.0 #563
Open
KumarADITHYA123 wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Fix : division by zero in sampling when temperature is 0.0 #563KumarADITHYA123 wants to merge 1 commit intogoogle-deepmind:mainfrom
KumarADITHYA123 wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes issue #562
This PR addresses a potential crash/undefined behavior where setting temperature=0.0 causes a division by zero in RandomSampling, TopkSampling, and TopPSampling.
Changes:
Added a guard clause to get_next_tokens in all three sampling classes.
If temperature < 1e-6, it now delegates to Greedy sampling (argmax), which is the expected behavior for zero temperature.
Added a unit test test_zero_temperature_behavior to _sampling_test.py to verify correctness.
This ensures deterministic output and prevents NaN or Inf values in logits when users explicitly request greedy decoding via temperature=0.0.