Skip to content

Fix shell argument limit #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ze2j wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix shell argument limit #1731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tools/common_compiler_flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,6 @@ def generate(env):
elif env["lto"] == "full":
env.Append(CCFLAGS=["-flto"])
env.Append(LINKFLAGS=["-flto"])

if env["platform"] == "linux" or env.get("use_mingw", False):
env["ARFLAGS"] = "rcs"
33 changes: 32 additions & 1 deletion tools/godotcpp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import os
import platform
import sys
import tempfile

import header_builders
from SCons import __version__ as scons_raw_version
Expand Down Expand Up @@ -545,6 +546,11 @@ def generate(env):
),
}
)
if env["platform"] == "linux" or env.get("use_mingw", False):
env.Append(
BUILDERS={"GodotStaticLibRspBuilder": Builder(action=Action(_build_static_lib_with_rsp, "$ARCOMSTR"))}
)

env.AddMethod(_godot_cpp, "GodotCPP")


Expand All @@ -560,6 +566,25 @@ def _get_api_file(extension_dir, api_version):
return path


def _build_static_lib_with_rsp(target, source, env):
target_lib = str(target[0])

with tempfile.NamedTemporaryFile(mode="w", suffix=".rsp", delete=False) as rsp_file:
rsp_path = rsp_file.name
for src in source:
rsp_file.write(str(src) + "\n")

try:
ar = env["AR"]
arflags = env.get("ARFLAGS", "")
command = "{} {} {} @{}".format(ar, arflags, target_lib, rsp_path)
env.Execute(command)
finally:
os.remove(rsp_path)

return None


def _godot_cpp(env):
extension_dir = normalize_path(env.get("gdextension_dir", default=env.Dir("gdextension").srcnode().abspath), env)
default_api_file = _get_api_file(extension_dir, env.get("api_version", None))
Expand Down Expand Up @@ -600,7 +625,13 @@ def _godot_cpp(env):
library_name = "libgodot-cpp" + env["suffix"] + env["LIBSUFFIX"]

if env["build_library"]:
library = env.StaticLibrary(target=env.File("bin/%s" % library_name), source=sources)
if env["platform"] == "linux" or env.get("use_mingw", False):
# Use a custom builder to aggregate object files into a static library using a temporary response file.
# This avoids hitting the shell argument limit.
library = env.GodotStaticLibRspBuilder(target=env.File("bin/%s" % library_name), source=env.Object(sources))
else:
library = env.StaticLibrary(target=env.File("bin/%s" % library_name), source=sources)

env.NoCache(library)
default_args = [library]

Expand Down
Loading