Templated and custom-named classes support and test#1362
Open
IvanInventor wants to merge 2 commits intogodotengine:masterfrom
Open
Templated and custom-named classes support and test#1362IvanInventor wants to merge 2 commits intogodotengine:masterfrom
IvanInventor wants to merge 2 commits intogodotengine:masterfrom
Conversation
0ef830f to
2642a84
Compare
Collaborator
|
Thanks! This is an interesting feature. However, one of the design goals of godot-cpp is to provide the same API as is available internally in Godot itself. So, for this to be added to godot-cpp, it'd need to be added first to Godot, so you'd need to propose it there first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for template classes, and, as side effect, classes with custom name, different for actual name.
To add template class:
GDCLASS()macro withGDCLASS_TEMPLATE()As a side effect after changes, classes with custom name are now also easily created with
GDCLASS_NAME(ExampleCustom, Object, "CustomExample");macro