Add is_class_static virtual method to GDCLASS macro.#1356
Open
limbonaut wants to merge 1 commit intogodotengine:masterfrom
Open
Add is_class_static virtual method to GDCLASS macro.#1356limbonaut wants to merge 1 commit intogodotengine:masterfrom
is_class_static virtual method to GDCLASS macro.#1356limbonaut wants to merge 1 commit intogodotengine:masterfrom
Conversation
Collaborator
|
Thanks! However, as I wrote on the proposal: one of godot-cpp's design goals is to have the same API as internally in the engine (at least as much as possible), so, to add an |
Contributor
|
In your usage, i think |
Author
|
It is possible to do this with the existing methods, just as in GDScript. What I propose is to add an efficient |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to proposal: godotengine/godot-proposals#8852
In the
godot-cpp, we already haveget_class_static()added byGDCLASSmacro. Having also an instance methodvirtual bool is_class_static(StringName cn)would provide an efficient comparison method to the already existing functionality.Usage