Fix WooCommerce Fatal Error #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eherman-godaddy
added
[Type] Bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a WooCommerce fatal error that occurs when using default permalinks with an empty cart when accessing the REST API. The issue arises because $woocommerce->cart may not be available in certain contexts.
- Adds a null check for
$woocommerce->cartbefore accessing its methods - Prevents fatal errors when the cart object is not initialized during REST API requests
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aledesma-godaddy
approved these changes
Sep 18, 2025
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of an edge case, and a strange one, but one that I caught while testing out other things with the REST API.
When using the default permalinks, and you have an empty cart, the site will fatal error because
$woocommerce->cartisn't available. This PR just adds a check to make sure it's available for use before we actually use it.Permalinks: Plain
URL: /wp-json/wp/v2/posts/