Skip to content

Fix where register_meta is hooked #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EvanHerman merged 7 commits into from
Apr 8, 2025
+20 −10
Merged

Fix where register_meta is hooked #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
23fa1a3
Fix where register_meta is hooked
EvanHerman Apr 8, 2025
d2edb80
Refactor
EvanHerman Apr 8, 2025
ff61ac9
Refactor
EvanHerman Apr 8, 2025
999c1d6
Add doc comment for register_meta
EvanHerman Apr 8, 2025
f0e6fb2
Update test
EvanHerman Apr 8, 2025
d11027c
Retrigger test
EvanHerman Apr 8, 2025
4afd5b4
Retrigger test
EvanHerman Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .dev/tests/php/test-title-meta.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ function test_hide_page_title_non_page() {
*/
function test_hide_page_title_callback() {

do_action( 'rest_api_init' );

$post_title_visible = $this->factory->post->create(
[
'post_title' => 'Show Post title',
Expand Down
28 changes: 18 additions & 10 deletions includes/title-meta.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,24 @@ function setup() {

add_filter( 'go_page_title_args', $n( 'hide_page_title' ) );

register_meta(
'post',
'hide_page_title',
array(
'sanitize_callback' => $n( 'hide_page_title_callback' ),
'type' => 'string',
'description' => __( 'Hide Page Title.', 'go' ),
'show_in_rest' => true,
'single' => true,
)
add_action(
'rest_api_init',
/**
* Register the meta field for the REST API.
*/
function() {
register_meta(
'post',
'hide_page_title',
array(
'sanitize_callback' => 'Go\Title_Meta\hide_page_title_callback',
'type' => 'string',
'description' => __( 'Hide Page Title.', 'go' ),
'show_in_rest' => true,
'single' => true,
)
);
}
);

}
Expand Down
Loading