Conversation
lfmoisa-globality
requested review from
albsadowski,
amenut,
andrewplumb,
marcglobality and
salmanmashayekh
as code owners
lfmoisa-globality
force-pushed
the
upgrade-python310
branch
from
c34ee9c to
b5e0cde
Compare
marcglobality
left a comment
marcglobality
left a comment
There was a problem hiding this comment.
LGTM. But let's wait for @salmanmashayekh who's the real owner of this
| @@ -1,4 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Author
There was a problem hiding this comment.
good call, we don't need the entire .idea.
We should never put IDE specific stuff, unless cross IDE. Not all people use idea.
There was a problem hiding this comment.
@lfmoisa-globality can you remove the folder? then I'll check with Salman and we can probably merge
|
btw, as we talked, maybe we could go to 3.11 directly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://globality.atlassian.net/browse/GLOB-77270
Why?