Skip to content

Conversation

@akanshaaa19
Copy link
Member

@akanshaaa19 akanshaaa19 commented Dec 10, 2025

whatsapp-forms/configure/1

…using dnd-kit

feat: create Configure component for WhatsAppForms with FormBuilder and Preview
style: add CSS styles for Configure, FormBuilder, Screen, and Preview components
refactor: update WhatsAppForms to include Google Sheet URL and remove unused formJson state
fix: add configure action in WhatsAppFormList for navigating to the Configure page
@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…add, update, delete, and reorder functionalities for content items
@akanshaaa19 akanshaaa19 linked an issue Dec 12, 2025 that may be closed by this pull request
12 tasks
…gement features, including screen state handling and improved styling
@cypress
Copy link

cypress bot commented Dec 18, 2025

Glific    Run #7038

Run Properties:  status check passed Passed #7038  •  git commit 13ae5fe3e1 ℹ️: Merge 10dc37ba455da23065a0c618ddf54af6490d042b into 74680675152cc4d95c2a63cbc1bf...
Project Glific
Branch Review whatsapp-forms-2/flow-builder-ui
Run status status check passed Passed #7038
Run duration 27m 51s
Commit git commit 13ae5fe3e1 ℹ️: Merge 10dc37ba455da23065a0c618ddf54af6490d042b into 74680675152cc4d95c2a63cbc1bf...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 190
View all changes introduced in this branch ↗︎

…including screen name and field label editing, and improved JSON viewer styling
…review functionality with dynamic content rendering
…e management and styling

- Enhanced FormBuilder component to accept expanded screen and content IDs as props.
- Refactored styles in FormBuilder, Screen, JSONViewer, Preview, and Variables components for consistency.
- Updated variable naming conventions in CSS modules to follow PascalCase.
- Improved the layout and structure of the Preview component for better user experience.
- Removed unused variables and streamlined the rendering logic in the Variables component.
@github-actions github-actions bot temporarily deployed to pull request January 15, 2026 08:18 Inactive
@priyanshu6238 priyanshu6238 changed the base branch from whatsapp-forms-2/create_sheet to whatsapp-forms-phase-2 January 15, 2026 08:29
@priyanshu6238 priyanshu6238 requested review from AmishaBisht and shijithkjayan and removed request for shijithkjayan January 15, 2026 08:33
@priyanshu6238 priyanshu6238 removed the request for review from AmishaBisht January 15, 2026 08:52
@priyanshu6238 priyanshu6238 added the on hold This is on hold label Jan 15, 2026
@shijithkjayan
Copy link
Member

@priyanshu6238 Please fix the conflicts

@AmishaBisht
Copy link
Collaborator

Screenshot 2026-01-16 at 4 17 12 PM According to the new form builder, we don’t need to go to the playground, right? So why do we still have this when we create the form? @priyanshu6238 @shijithkjayan any idea? I might be missing something.

@priyanshu6238
Copy link
Collaborator

Screenshot 2026-01-16 at 4 17 12 PM According to the new form builder, we don’t need to go to the playground, right? So why do we still have this when we create the form? @priyanshu6238 @shijithkjayan any idea? I might be missing something.

Yes, we don’t need this. I reviewed the code in the morning . there are a few details missing in the UI, and it’s not fully ready yet.

@AmishaBisht
Copy link
Collaborator

Yes, we don’t need this. I reviewed the code in the morning . there are a few details missing in the UI, and it’s not fully ready yet.

okat let;s remove it then
cc: @shijithkjayan

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 35.30151% with 515 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.81%. Comparing base (7468067) to head (10dc37b).

Files with missing lines Patch % Lines
...ppForms/Configure/FormBuilder/FormBuilder.utils.ts 19.82% 173 Missing and 9 partials ⚠️
...hatsAppForms/Configure/FormBuilder/FormBuilder.tsx 22.50% 60 Missing and 2 partials ⚠️
...ure/FormBuilder/ContentItem/types/MediaContent.tsx 1.81% 54 Missing ⚠️
...FormBuilder/ContentItem/types/SelectionContent.tsx 2.32% 42 Missing ⚠️
...c/containers/WhatsAppForms/Configure/Configure.tsx 52.00% 28 Missing and 8 partials ⚠️
...rs/WhatsAppForms/Configure/Variables/Variables.tsx 32.50% 26 Missing and 1 partial ⚠️
...ormBuilder/ContentItem/types/TextAnswerContent.tsx 4.00% 24 Missing ⚠️
...tsAppForms/Configure/FormBuilder/Screen/Screen.tsx 32.35% 14 Missing and 9 partials ⚠️
...ainers/WhatsAppForms/Configure/Preview/Preview.tsx 73.77% 4 Missing and 12 partials ⚠️
...e/FormBuilder/ContentItem/ContentItemComponent.tsx 6.25% 15 Missing ⚠️
... and 6 more
Additional details and impacted files
@@                    Coverage Diff                     @@
##           whatsapp-forms-phase-2    #3689      +/-   ##
==========================================================
- Coverage                   82.75%   79.81%   -2.95%     
==========================================================
  Files                         317      334      +17     
  Lines                       11884    12633     +749     
  Branches                     2492     2723     +231     
==========================================================
+ Hits                         9835    10083     +248     
- Misses                       1286     1749     +463     
- Partials                      763      801      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@priyanshu6238 priyanshu6238 added status: ready for review and removed on hold This is on hold labels Jan 20, 2026
@AmishaBisht
Copy link
Collaborator

Screenshot 2026-01-21 at 12 01 51 AM

The cross button and the three dots don’t do anything. Why do we have them? @priyanshu6238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Whatsapp Forms Phase 2: Add flow builder UI

5 participants