-
Notifications
You must be signed in to change notification settings - Fork 9
Update Bhashini Integrations.md #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed the screenshot + step in the steps of 'Using `open_ai` for TTS' with corrected syntax of using the speech engine. Added a line clarifying the current limitation that this can only be used when the source and target languages are the same.
📝 WalkthroughWalkthroughDocumentation update to the Bhashini Integrations guide corrects the OpenAI speech engine parameter from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 Deployed on https://deploy-preview-537--glific-docs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/5. Integrations/Bhashini Integrations.md
🔇 Additional comments (2)
docs/5. Integrations/Bhashini Integrations.md (2)
139-140: Syntax correction for speech engine parameter is accurate.The change from
open-ai(hyphen) toopen_ai(underscore) directly addresses issue #532 and provides the correct configuration value users should apply.
141-142: Language parity constraint clarification is clear and appropriately placed.The note effectively communicates an important operational constraint—that OpenAI TTS currently requires source and target languages to be identical. This prevents user confusion and misconfiguration.
| - Keep the remaining steps the same as those mentioned in the Text-to-Speech section above. | ||
|
|
||
| <img width="590" height="412" alt="Screenshot 2025-09-25 at 1 00 36 AM" src="https://github.com/user-attachments/assets/1111db5f-137d-4825-8ca9-d3e6a00fe53f" /> | ||
| <img width="624" height="433" alt="Screenshot 2025-12-31 at 4 42 02 PM" src="https://github.com/user-attachments/assets/61d2884a-4dc4-4e36-bbe6-f8aa895a0cc1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
# Check screenshot URL accessibility
curl -sI https://github.com/user-attachments/assets/61d2884a-4dc4-4e36-bbe6-f8aa895a0cc1 | head -1
# Also check the file to see surrounding context
if [ -f "docs/5. Integrations/Bhashini Integrations.md" ]; then
echo "=== File context around line 145 ==="
sed -n '130,150p' "docs/5. Integrations/Bhashini Integrations.md"
fiRepository: glific/docs
Length of output: 1167
Screenshot URL returns a redirect instead of direct content.
The screenshot URL (https://github.com/user-attachments/assets/61d2884a-4dc4-4e36-bbe6-f8aa895a0cc1) returns an HTTP 302 redirect rather than a 200 status. While the image may still load in browsers, consider linking directly to the image file or using a direct CDN URL for better reliability in documentation.
Additionally, the screenshot placement supports the general configuration instruction to set the speech engine to open_ai, but there is no evidence of a specific syntax correction being demonstrated at the referenced lines.
🤖 Prompt for AI Agents
In docs/5. Integrations/Bhashini Integrations.md around line 145, the embedded
screenshot uses a GitHub user-attachments URL that responds with a 302 redirect;
replace the image reference with a direct image/CDN URL (or commit the image to
the repo and reference it via raw.githubusercontent.com) so the link returns 200
and is reliably rendered, and add a short inline note or code snippet at the
same location showing the exact syntax to set the speech engine to "open_ai" to
make the configuration correction explicit.
Changed the screenshot + step in the steps of 'Using
open_aifor TTS' with corrected syntax of using the speech engine.Added a line clarifying the current limitation that this can only be used when the source and target languages are the same.
Corrected step reference from
Speech-to-TexttoText-to-Speech./close #532
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.