-
Notifications
You must be signed in to change notification settings - Fork 9
Update Custom Certificates.md #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added additional use cases of this feature such as leaderboards, showing progression elements (progress bar+rings) - Deleted the line that calls out that this includes a feature flag, as it has been enabled for all orgs now.
WalkthroughThis pull request updates the Custom Certificates documentation by adding information about gamified visual elements (leaderboards, progress rings/bars, milestone progression) that can be sent via flows, and removes the prior statement designating the feature as trial-only with beta enrollment requirements. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 Deployed on https://deploy-preview-528--glific-docs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/4. Product Features/Custom Certificates.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/4. Product Features/Custom Certificates.md
[style] ~21-~21: In American English, abbreviations like “etc.” require a period.
Context: ...ess ring/bar, progression to milestones etc, that can be sent out through flows. ...
(ETC_PERIOD)
🔇 Additional comments (1)
docs/4. Product Features/Custom Certificates.md (1)
15-23: Overview & Pre-requisites integration looks good.The new sentence at line 21 effectively addresses the PR objectives by introducing leaderboards and progression elements as concrete use cases. The content flows naturally into the Pre-requisites section. The removal of the trial/beta enrollment language simplifies the entry point for users.
| Using this feature organizations can upload multiple certificate or badge templates, and share these for the contacts having their personalized information such as "name", or "course participation", "course completion" details or any other such contact specific details be printed on the certificates and have the certificate shared with the contacts through the flows. | ||
|
|
||
| ## Pre-requisites | ||
| In effect, this feature also enables users to create visual gamified elements such as leaderboards, progress ring/bar, progression to milestones etc, that can be sent out through flows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix punctuation: "etc" should be "etc."
In American English, abbreviations like "etc." require a period. Additionally, consider improving parallel structure for "progress ring/bar" by writing it as "progress bars/rings" or "progress rings/bars" for consistency.
-In effect, this feature also enables users to create visual gamified elements such as leaderboards, progress ring/bar, progression to milestones etc, that can be sent out through flows.
+In effect, this feature also enables users to create visual gamified elements such as leaderboards, progress bars/rings, and progression to milestones, etc., that can be sent out through flows.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| In effect, this feature also enables users to create visual gamified elements such as leaderboards, progress ring/bar, progression to milestones etc, that can be sent out through flows. | |
| In effect, this feature also enables users to create visual gamified elements such as leaderboards, progress bars/rings, and progression to milestones, etc., that can be sent out through flows. |
🧰 Tools
🪛 LanguageTool
[style] ~21-~21: In American English, abbreviations like “etc.” require a period.
Context: ...ess ring/bar, progression to milestones etc, that can be sent out through flows. ...
(ETC_PERIOD)
🤖 Prompt for AI Agents
In docs/4. Product Features/Custom Certificates.md around line 21, fix
punctuation and parallel structure: add a period after "etc" to use "etc." and
normalize the "progress ring/bar" phrase to a consistent parallel form such as
"progress rings/bars" (or "progress bars/rings") so the list reads smoothly and
follows American English conventions.
Closes #523
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.