gh-947: split positions_from_delta into internal functions
#950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
added
enhancement
paddyroddy
commented
Jan 8, 2026
tests/fixtures/helper_classes.py
Outdated
| def assert_equal(actual: AnyArray, desired: AnyArray) -> None: | ||
| """Check if two objects are not equal.""" | ||
| np.testing.assert_equal(actual, desired) | ||
| np.testing.assert_equal(np.asarray(actual), np.asarray(desired)) |
Member
Author
There was a problem hiding this comment.
Run into issues comparing non-NumPy arrays, even though they look the same
Co-authored-by: Connor Aird <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split up the
positions_from_deltafunction. The function is doing too much and is cumbersome to test. We've also noticed that it regularly fails the benchmarking. This will take some work to get to something we are happy with. This first step creates some internal functions that can be individually tested.Closes: #947
Checks