fix: install correct version in action#19591
Closed
harrisoncramer wants to merge 4 commits intogithub:mainfrom
Closed
fix: install correct version in action#19591harrisoncramer wants to merge 4 commits intogithub:mainfrom
harrisoncramer wants to merge 4 commits intogithub:mainfrom
Conversation
harrisoncramer
commented
Mar 4, 2026
Comment on lines
+85
to
+86
| # Test 5: Verify version pinning support | ||
| test_version_pinning() { |
Author
There was a problem hiding this comment.
This functionality seems to be an old test that was never cleaned up.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the setup action’s gh extension install path so that specifying a version actually installs that version (instead of always installing the latest).
Changes:
- Add
--pin <version>when a non-latestversion is requested forgh extension install. - Update the action output to report the detected installed version from
gh aw version. - Replace the prior validation test with a new test that checks for version pinning support.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| actions/setup-cli/install.sh | Adds version-pinning logic for gh extension install and adjusts the reported installed_version. |
| actions/setup-cli/install_test.sh | Updates tests to check for --pin usage in the installer script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 4, 2026
Contributor
|
@copilot review install updates |
Copilot AI
added a commit
that referenced
this pull request
Mar 4, 2026
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
3 tasks
Copilot AI
added a commit
that referenced
this pull request
Mar 4, 2026
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
|
Merged in other PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
install.shscript was usinggh extension install github/gh-aw --forcewhich always installs the latest version, completely ignoring the specified version input.Changes Made
File: actions/setup-cli/install.sh:241-248
--pinflag to install the specific version:INSTALL_CMD="gh extension install \"$REPO\" --force --pin \"$VERSION\""Testing
All tests pass (6/6), including the new test that specifically validates version pinning functionality.