Remove unused registry types from LANGUAGE_TO_REGISTRY_TYPE#3527
Open
Remove unused registry types from LANGUAGE_TO_REGISTRY_TYPE#3527
LANGUAGE_TO_REGISTRY_TYPE#3527Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a feature-flagged “reduced” registry-type allowlist for the start-proxy action so that only the ecosystems that are actually supported for private registries are considered when filtering credentials.
Changes:
- Add a new
StartProxyRemoveUnusedRegistriesfeature flag and plumb it intostart-proxy-action. - Add a second registry-type mapping (
NEW_LANGUAGE_TO_REGISTRY_TYPE) and use it when the feature flag is enabled. - Add unit tests covering the Actions-language behavior under both mappings.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/start-proxy.ts | Adds a feature-flag-controlled registry-type mapping used to filter credentials by language. |
| src/start-proxy.test.ts | Adds tests for getCredentials behavior with KnownLanguage.actions under both mappings. |
| src/start-proxy-action.ts | Reads the feature flag and passes it into getCredentials. |
| src/feature-flags.ts | Defines the new StartProxyRemoveUnusedRegistries flag and its config. |
| lib/* | Generated JS output updates corresponding to the TypeScript changes. |
Member
Author
|
@sam-robson Thanks for reviewing! One of Copilot's review comments was reasonable, so I have pushed a commit which makes that change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unused registry types from
LANGUAGE_TO_REGISTRY_TYPE. Currently we only support private registries for Java (maven_repository), C# (nuget_feed), and Go (git_source,goproxy_server). However, the configuration inLANGUAGE_TO_REGISTRY_TYPEallows other registry types for other languages to be enabled in CodeQL workflows. This may give users the wrong impression that those types of registries are actually supported.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist