Skip to content

fix: double-clicking a checkmark icon should keep current cell selection #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghiscoding merged 3 commits into from
Jan 12, 2026
Merged

fix: double-clicking a checkmark icon should keep current cell selection #2312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eecaf1d
fix: double-clicking a checkmark icon should keep current cell selection
ghiscoding Jan 10, 2026
d32afb7
chore: use `user-select: none` instead
ghiscoding Jan 12, 2026
bbc6691
chore: revert to inline-flex
ghiscoding Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/common/src/styles/slickgrid-icons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,7 +953,7 @@
);

.mdi {
display: inline-block;
display: inline-flex;
align-items: center;
background-color: currentColor;
font-size: v.$slick-icon-font-size;
Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/styles/svg-utilities.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ $svg-icon-vertical-align: bottom !default;
// we will also use the name to create a CSS variable so that user could override any of the icon
// by providing the full url string without needing else since it was already created
@mixin generateSvgStyle($cssVarName, $svgPath) {
--#{$cssVarName}: url('data:image/svg+xml;utf8,%3Csvg viewBox="0 0 24 24" display="inline-block" height="1em" width="1em" vertical-align="text-bottom" xmlns="http://www.w3.org/2000/svg" %3E%3Cpath fill="currentColor" d="#{$svgPath}"/%3E%3C/svg%3E');
--#{$cssVarName}: url('data:image/svg+xml;utf8,%3Csvg viewBox="0 0 24 24" height="1em" width="1em" vertical-align="text-bottom" xmlns="http://www.w3.org/2000/svg" %3E%3Cpath fill="currentColor" d="#{$svgPath}"/%3E%3C/svg%3E');
-webkit-mask: var(--#{$cssVarName}) no-repeat;
mask: var(--#{$cssVarName}) no-repeat;
mask-size: 100% 100%;
Expand Down
Loading