Draft
Conversation
Signed-off-by: Felix Fontein <felix@fontein.de>
Contributor
Author
|
Related: yaml/go-yaml#34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One annoying thing with SOPS-encrypted files is that all whitespace is normalized, and most importantly empty lines are removed.
I've been thinking for some time whether we can do better, so I did an experiment:
gopkg.in/ini.v1).I guess for JSON it's OK to ignore newlines, but for INI and YAML it would be really nice. Especially for YAML, which I consider the main format for SOPS. Maybe this will be better with https://github.com/goccy/go-yaml...
I'm creating a PR for this experiment so that others can take a look, and maybe it's possible to improve on this once/if we switch to https://github.com/goccy/go-yaml.