bump,update: Stop doing the weird aligning things with colons #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've always done this thing where the colons in `package.yml` files were aligned; but only the top-level ones. While it arguably looks nicer (I personally disagree), it also makes it really hard to work with other YAML tooling, such as formatters. It also kept us from being able to automatically sort dependencies. Let's do away with it, unlocking us to use more standard tools. Signed-off-by: Evan Maddock <[email protected]>
EbonJaeger
force-pushed
the
no-more-weird-colon-things
branch
from
ce41540 to
595206d
Compare
sheepman4267
approved these changes
Dec 8, 2025
Member
sheepman4267
left a comment
sheepman4267
left a comment
There was a problem hiding this comment.
Does what it says on the tin. This should be merged and deployed before the mass conversion of package files.
Contributor
|
1000 thumbs up from me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've always done this thing where the colons in
package.ymlfiles were aligned; but only the top-level ones. While it arguably looks nicer (I personally disagree), it also makes it really hard to work with other YAML tooling, such as formatters. It also kept us from being able to automatically sort dependencies. Let's do away with it, unlocking us to use more standard tools.Test Plan
virtualenv venvsource venv/activate.fishpip install .ybump ~/repos/getsolus/solus-packages/packages/n/nano/package.yml