feat(snapshots): Set nice UI for left side of header#111822
Merged
NicoHinderling merged 2 commits intomasterfrom Mar 30, 2026
Merged
feat(snapshots): Set nice UI for left side of header#111822NicoHinderling merged 2 commits intomasterfrom
NicoHinderling merged 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
40b217d to
5b098d2
Compare
rbro112
approved these changes
Mar 30, 2026
dashed
pushed a commit
that referenced
this pull request
Apr 1, 2026
before: <img width="1510" height="694" alt="CleanShot 2026-03-30 at 13 35 40@2x" src="https://github.com/user-attachments/assets/c8425aea-5d0c-42d2-8b98-40bab7ac3237" /> after: <img width="1512" height="682" alt="CleanShot 2026-03-30 at 13 36 50@2x" src="https://github.com/user-attachments/assets/cc5ab558-01a8-4399-9eee-047254148bc1" /> ## Summary Redesigns the snapshot page header (top-left section) with a cleaner layout: - **Title**: Changed from "Snapshots" to singular "Snapshot", removed breadcrumbs and feature badge - **VCS metadata row**: PR number, commit SHA, and branch name now display with proper icons (`IconPullRequest`, `IconCommit`, `IconStack`) and purple linked text - **Comparing row**: New "Comparing: **Head** vs **Base**" section for diff-mode snapshots - **Head** button toggles between diff and solo view (`?view=solo` query param) - **Base** button navigates to the base artifact's snapshot page - Both use pill-shaped buttons with accent-colored eye icons Uses Sentry design system components (`Button`, `LinkButton`, `Text`, `Flex`, `ExternalLink`) throughout. VCS items are rendered from a declarative config array for cleaner code. ## Test plan - [ ] Visit a snapshot page with diff comparison data (e.g. `/preprod/snapshots/169382/`) - [ ] Verify header shows "Snapshot" title, VCS info row with correct icons and purple links - [ ] Verify "Comparing" row appears with Head and Base pill buttons - [ ] Click Head → URL gets `?view=solo`, button turns primary (purple), content switches to solo view - [ ] Click Head again → returns to diff view - [ ] Click Base → navigates to base artifact's snapshot page - [ ] Verify VCS links (PR, commit, branch) open correct GitHub URLs - [ ] Visit a solo-mode snapshot (no base) → "Comparing" row should not appear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


before:

after:

Summary
Redesigns the snapshot page header (top-left section) with a cleaner layout:
IconPullRequest,IconCommit,IconStack) and purple linked text?view=soloquery param)Uses Sentry design system components (
Button,LinkButton,Text,Flex,ExternalLink) throughout. VCS items are rendered from a declarative config array for cleaner code.Test plan
/preprod/snapshots/169382/)?view=solo, button turns primary (purple), content switches to solo view